3482 update pointing attitude job to use start date and minor version

[tmplummer]

Change Summary

Update the pointing attitude job to use the batch-provided start date (from dagster's custom partitioning) as the coverage floor, and to use the batch-provided minor version for the output DPS kernel filename.

Overview

Previously, pointing_frame.py derived its own coverage start date from the earliest time covered by the input CK files, and named the output DPS kernel using the version parsed from the input CK filename. With dagster now supplying a partition start date and minor version via the batch command, the job should respect those instead:Coverage start is now max(batch start_date, CK coverage start) — narrows output to the requested date while still guaranteeing any selected pointing is fully
covered by the input CKs (avoids selecting a pointing with no actuThe existing "first fully covered pointing" selection logic is unchanged.

• The DPS kernel filename version now comes from the batch command'sbeing parsed off an input CK file.
  File changes
• imap_processing/spice/pointing_frame.py: calculate_pointing_attituointing_attitude_kernel now accept start_date; kernel filename versionbuilt from a new minor_version param instead of the input CK's filename version.
• imap_processing/cli.py: Spacecraft.do_processing resolves the mino-attitude descriptor and passes it along with self.start_date togenerate_pointing_attitude_kernel.
• imap_processing/tests/spice/test_pointing_frame.py, imap_processined for the new signatures; added a test verifying start_date canexclude an otherwise fully-covered pointing.

Testing

• pytest imap_processing/tests/spice/test_pointing_frame.py imap_processing/tests/test_cli.py — 59 passed.

Closes: #3482

[Copilot]

Copilot review overview

🟡 Changes recommended

Unresolved CLI error paths can cause unhandled exceptions.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 · 1 · 1

Open (3)

• Reject missing start date before parsing repointing descriptor · New
• Handle missing dependency version fallback before lstrip · New
• Add coverage for batch Version and pointing-attitude version paths · New

What changed in this PR

Updates pointing-attitude generation to use the batch-provided start date and minor version.

Changes:

• Narrows coverage using the requested start date.
• Uses the batch minor version for DPS kernel filenames.
• Updates CLI forwarding and tests.

File	Summary	Review notes
imap_processing/​tests/​test_cli.py	Tests CLI argument propagation.	Nit (2 votes): Add coverage for the resolved minor-version and dependency-map paths.
imap_processing/​tests/​spice/​test_pointing_frame.py	Tests start-date filtering and filename behavior.	—
imap_processing/​spice/​pointing_frame.py	Applies start-date filtering and version-based naming.	—
imap_processing/​cli.py	Passes the batch date and resolved minor version.	Critical (2 votes): Handle missing self.start_date for --repointing. Moderate (2 votes): Handle a missing version fallback explicitly.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Copilot review overview

🟢 Approval recommended

The reviewed changes and tests cover the requested behavior with no unresolved blocking issues.

Review effort: Lite
Findings: None

Resolved since last review (3)

• Reject missing start date before parsing repointing descriptor
• Handle missing dependency version fallback before lstrip
• Add coverage for batch Version and pointing-attitude version paths

[lacoak21]

LGTM!