Tweaked values for gf* in the lo gf ancillary - #3473
Open
vineetbansal wants to merge 2 commits into
Open
vineetbansal wants to merge 2 commits into
vineetbansal wants to merge 2 commits into
Conversation
…ond to gf/dgu/dgl columns in 3S5_l1b_ram_maps/map_SCFrame_V2.py on dropbox code
Collaborator
Author
|
@frahmanif - the task here is to simply ensure that the gf/dgu/dgl values used in the SDC pipeline and the dropbox pipeline are mutually consistent. I don't know where the authoritative values sit, so the fix could be in either direction. This PR tweaks the SDC's values, but if the fix is in the dropbox pipeline, we can make the changes there. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3472
A diff against the v004 version of the ancillary file in the SDC pipeline will show that only the precision of 3 columns has changed to match the numbers I find in https://github.com/vineetbansal/imap-lo/blob/main/3S5_l1b_ram_maps/map_SCFrame_V2.py
A complete snippet of code to produce these 3 columns is (only the
printlines are mine - everything else is from3S5_l1b_ram_maps/map_SCFrame_V2.py:This needs to be signed off by someone on the Lo team.