Skip to content

CoDICE l2 sw species attribute fix - #3465

Merged
lacoak21 merged 2 commits into
IMAP-Science-Operations-Center:devfrom
lacoak21:codice_fix_l2_lo_sw_species_dims
Sep 18, 2026
Merged

lacoak21 merged 2 commits into
IMAP-Science-Operations-Center:devfrom
lacoak21:codice_fix_l2_lo_sw_species_dims

Conversation

@lacoak21

Copy link
Copy Markdown
Contributor

Change Summary

closes #3464

Overview

Fix the attribute dimension switch.

@lacoak21
lacoak21 requested a review from tech3371 September 16, 2026 17:31
@lacoak21 lacoak21 self-assigned this Sep 16, 2026
@lacoak21 lacoak21 added this to IMAP Sep 16, 2026
@lacoak21
lacoak21 requested a balanced review from Copilot September 16, 2026 17:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The shared attribute removal incorrectly detaches CoDICE Lo L1B energy variables and labels from their esa_step dimension.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Fixes CoDICE L2 solar-wind species energy-axis metadata.

Changes:

  • Swaps the species dimension to physical energy-per-charge.
  • Adds CDF round-trip and dependency assertions.
  • Updates CDF attributes and generated version metadata.
File summaries
File Description
codice_l2.py Switches the L2 species energy dimension.
test_codice_l2.py Tests CDF loading and dependencies.
imap_codice_l1b_variable_attrs.yaml Removes L1B energy dependencies.
_version.py Updates generated version metadata.
Review details

Suppressed comments (1)

imap_processing/cdf/config/imap_codice_l1b_variable_attrs.yaml:19

  • The label is also produced on esa_step for every CoDICE Lo L1B product (codice_l1b.py:77-89), so deleting this dependency leaves those L1B labels detached from their axis. Restore the L1B metadata; the L2 branch explicitly changes the copied label's dependency to energy_per_charge.
    CATDESC: Energy per charge
  • Files reviewed: 4/4 changed files
  • Comments generated: 1
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread imap_processing/cdf/config/imap_codice_l1b_variable_attrs.yaml
Comment thread imap_processing/_version.py

@leowerneck leowerneck left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I approved because I'm not sure the imap_processing/_version.py change is supposed to be made or not (my understanding is it shouldn't be updated). In either case, the fix (if required) it simple enough that doesn't warrant a new review.

@lacoak21
lacoak21 merged commit bfbd0d3 into IMAP-Science-Operations-Center:dev Sep 18, 2026
22 checks passed
@lacoak21
lacoak21 deleted the codice_fix_l2_lo_sw_species_dims branch September 18, 2026 15:23
@github-project-automation github-project-automation Bot moved this to Done in IMAP Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

CoDICE l2 sw species attribute bug

3 participants