IDEX IG velocity estimate limiter - #3463
Merged
lacoak21 merged 2 commits intoSep 22, 2026
Merged
Conversation
aldo9253
marked this pull request as draft
September 16, 2026 16:45
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The implementation bounds charge ratio rather than the specified 1–100 km/s velocity range.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Attempts to constrain IDEX Ion Grid velocity and mass estimates to calibrated limits.
Changes:
- Converts charge ratios to percentages for velocity calibration.
- Adds ratio validation and parameterized boundary tests.
File summaries
| File | Description |
|---|---|
idex_l2a.py |
Adds calibration conversion and validation. |
idex_constants.py |
Clarifies calibration units. |
test_idex_l2a.py |
Adds ratio-boundary coverage. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
lacoak21
reviewed
Sep 22, 2026
lacoak21
left a comment
lacoak21
left a comment
Contributor
There was a problem hiding this comment.
Looks good but there is still a pending comment. I will approve when its addressed.
lacoak21
marked this pull request as ready for review
September 22, 2026 18:49
lacoak21
self-requested a review
September 22, 2026 20:27
lacoak21
approved these changes
Sep 22, 2026
lacoak21
merged commit Sep 22, 2026
6dce0a9
into
IMAP-Science-Operations-Center:dev
22 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
Closes #3462
Restrict IDEX Ion Grid velocity estimates to the inclusive range of 1–100 km/s. Estimates outside this range and their corresponding mass estimates are set to NaN. Fitted charges and waveform fits remain unchanged.
File changes
Testing