Conversation
lacoak21
requested review from
bryan-harter,
mstarkey2158 and
tech3371
and
a balanced review from Copilot
September 14, 2026 16:28
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The valid maximum must also be converted from 625 ms to 0.625 s.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Corrects CoDICE L1A acquisition-time metadata to use seconds.
Changes:
- Changes
acquisition_time_per_esa_stepunits from milliseconds to seconds.
File summaries
| File | Description |
|---|---|
imap_processing/cdf/config/imap_codice_l1a_variable_attrs.yaml |
Updates acquisition-time units. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+183
to
184
| UNITS: s | ||
| VALIDMAX: 625.000000 |
Collaborator
|
@lacoak21 Changes look good to me. |
tech3371
approved these changes
Sep 14, 2026
lacoak21
merged commit Sep 14, 2026
ec85f8d
into
IMAP-Science-Operations-Center:dev
22 checks passed
Contributor
Author
|
@mstarkey2158 - did you want all of l1a reprocessed? FYI this will be a full mission reprocess if so. Not an issue but I just wanted to confirm. |
Collaborator
|
@lacoak21 I think we should so that the units are correct in the L1a files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
closes #3456
Overview
Fix attribute units