fix: resolve nested remote schema references - #160
Merged
Conversation
Himenon
force-pushed
the
codex/issue-90-remote-reference
branch
4 times, most recently
from
September 7, 2026 13:16
bb773a3 to
80202dd
Compare
Himenon
force-pushed
the
codex/issue-90-remote-reference
branch
from
September 7, 2026 13:20
80202dd to
6989bd0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes Issue #90, where a schema referenced from a remote document could contain another local reference and cause a stack overflow during code generation.
Reference resolution now uses the document containing each reference as the base point, and traverses nested local and remote references across multiple documents. The regression scenario covers the following chain:
v1 → v0#/components/schemas/Book → v0#/components/schemas/BookIDAlias → v2#/components/schemas/BookIDThe implementation also detects circular schema references and includes Japanese comments explaining the reference-resolution flow.
Test Plan
The change follows a two-commit TDD sequence:
RangeError: Maximum call stack size exceededinfindSchemaByPathArray.Verification:
pnpm testpasses: 43 unit tests and 55 snapshot tests.Closes #90