Repository navigation
refactor: 按注释规则收短 fork 注释,把上游文件里的 fork 逻辑挪进自有类 - #176
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settings的抽屉头图块、EhApplication.update()(只去掉调用,fix: 阅读器新手引导 overlay 每次启动都重新弹出(versionCode 重置引入的回归) #33 的修复不变)、SpiderQueen的两行注释、GalleryHolder的 import、FavoritesScene的原写法Settings.java挪到新类NetworkStorageSettings;并发设置进SmbConcurrency,通知权限标记进NotificationPermission,库存排序进LocalInventoryScene,旧开关迁移进PowerDownloadSettings。key 字符串不变,不需要迁移;Settings.java只剩两行调用和一处可见性改动MainActivity的 edge-to-edge 处理挪进EdgeToEdgeInsets,抽屉「SMB Library」项交给LocalInventoryScene.updateDrawerItemDownloadTargetDialog,选项文字复用PowerDownloadTarget.labelRemoteSpiderInfo,SpiderQueen里的调用都插在原样保留的上游代码块之后;jcifs 主线程保护移到SmbSpiderStorage;SpiderDen.contain()恢复上游那一行SharePageRepair;读 SMB 进度文件头统一用SmbGalleryFiles.readSpiderInfoHeader,SmbGalleryLifecycle也改用它SmbDownloadsDelegate,FAB 让出分页条的位置挪进FabPaginationClearanceReaderPowerDownload,音量键翻页的互斥确认挪进VolumeKeyModeDialogCommonOperations.startDownloadWithoutAsking改为PowerDownloader的私有方法,CommonOperations与上游一致;原来的 4 个测试并入PowerDownloaderTestContentLayout.replaceAt,库存行替换改用上游已有的getData();下载适配器里两次行绑定调用合成一次;删掉 fork 文件里没用的 importSmbGalleryLifecycle读页数时只读文件头并核对 gid;getSmbClientId不再吞掉读取 ANDROID_ID 时的异常验证:LXC 上 CI 同款构建通过,单测 406 个 0 失败,androidTest 编译通过,release 构建的 lintVital 通过;18 个提交逐个能编译(拆分出的提交单独编译过,其余与跑过全量测试的版本相同或只差注释)。平板(SM-X926B,Android 16)上装了本分支构建(保留数据):已有设置全部读对(抽屉「SMB Library」、网络存储页、Power Download 页、库存排序);
SmbWorkflowTest6 个、ImageDecodeTest1 个全部通过;手工走过详情页「下载到哪」对话框、共享库画廊进阅读器(页面从共享库加载,主线程保护生效,阅读进度写回且不变)、长按菜单的「下载到手机」、已下载本子上的菜单项和音量上键(提示已下载,不改音量)、两处音量键翻页互斥确认、下载列表多选和全选。全程没有崩溃,没有任何下载写进共享库,测试前后 16 个相关设置逐项一致。未验证:下载列表里其他设备的 SMB 任务行(共享库上目前没有这类任务);工作线程从共享库读阅读进度(这条流程主线程会先用本地缓存,硬触发会改掉真实库里的阅读进度),只有单测;会写共享库的路径(刷新页回传、库存重新同步、对话框里真正开始下载)没在平板上点;旧开关迁移(平板上已没有旧 key)只有单测;
SmbReadWorkflowTest要 NAS 凭据,没跑。