Repository navigation
Fix detail action button lookup in the mod info panel - #2
Merged
Merged
Conversation
The Config and Alias/Notes buttons are created under BetterModMenuDetailActionRow, but Refresh looked them up directly under the action root. GetNode returned null, and the NullReferenceException aborted the NModdingScreen._Ready postfix before UpdateChromeLayout, the deferred backup check and the first-run tutorial. Generated with Claude Code (Claude Opus 5.5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an exception during the Modding screen's initialization. Notably, the Config button never showed its disabled state, and OK in the Alias/Notes popup didn't close the popup.
The Config and Alias/Notes buttons were being searched one level too high during
Refreshand returning null. The fix looks them up throughActionRowName.[panel with fix]
Version
Tested on Slay the Spire 2 v0.111.0 (
public-beta), Windows🤖 Code generated with Claude Code