Repository navigation
Place the top bar between the vanilla header and the mods panel - #1
Merged
Merged
Conversation
Inline on the title row, the profile bar covered the vanilla Make Mods and Get Mods buttons. Always lay it out at the panel's width, directly under the header: lower the panel's top edge by the bar's height and keep the header where it was. Generated with Claude Code (Claude Opus 5.5)
The top bar is always placed under the vanilla header now, so the inline title-row layout, ShouldStackTopBar (and its rule and test), and the TopBarGap / TopBarTrailingPadding constants are no longer used. Generated with Claude Code (Claude Opus 5.5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The profile bar in mod settings is positioned to the right of the "Installed Mods" title, which overlaps with the "Make Mods" and "Get Mods" buttons. This fix places the profile bar beneath the vanilla header, above the left panel. The now unused ShouldStackTopBar calculations and related tests were removed.
[Before]
[After]
Version
Tested on Slay the Spire 2 v0.111.0 (
public-beta), Windows, 2560x1440 and various windowed sizes🤖 Claude Code was used to generate the code.