Expose mergeable camera-shake rate bins for p99 - #628
Merged
Merged
Conversation
kstonekuan
marked this pull request as ready for review
September 26, 2026 00:07
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Camera-shake summaries currently discard assessed frame-pair rates after computing mean, RMS, and maximum. That prevents consumers from calculating a run-wide p99 across windows without decoding media again.
This adds assessed-duration rate bins to the existing one-pass summary and a duration-weighted percentile helper. Bins are one degree per second below 4,096°/s and 64 per doubling above it, keeping memory bounded. The helper returns the selected bin's upper bound, capped by the observed maximum. Compensated per-bin accumulation and precise prefix sums keep 30 fps percentile boundaries stable without treating a genuinely below-threshold bin as complete. Existing mean, RMS, maximum, and coverage calculations are unchanged.
Validation: Ruff, ty, 2,385 tests passed (8 skipped), including exact-boundary and below-threshold regressions.