Repository navigation
Add agent execution with reviewed edits and approved verification - #73
Merged
Merged
Conversation
Hanjo92
marked this pull request as ready for review
October 1, 2026 12:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and behavior
NoPilot's Agent mode previously produced planning text, and chat responses could be applied to whichever editor/selection was active later. This change pins the request's document URI, version, and range, and adds a bounded execution flow: inspect workspace files → propose reviewed edits → obtain approval → run separately approved verification → feed the actual result back to the model.
Implementation and safeguards
test,lint,compile, andbuild. Approval shows the script, working directory, proposed buffer saves, and side effects. Existing user edits are not auto-saved. Changed package.json or buffers invalidate approval.npm --ignore-scripts run <name>with pre/post hooks disabled, a 120-second timeout, bounded output, and cancellation of the process group. Approved project scripts run with the user's permissions and are not sandboxed; they may modify files or access the network.Validation
GitHub Actions CI run 36863966695: passed for head commit
35b319ad66b307f6b5a0376a65f7ebddd19bc780. All validation steps completed successfully.npm run compile,npm run lint,npm run build, andgit diff --check: passed.npm test: 201 tests passed (191 compiled tests + 10 runtime tests).Extension Host harness typecheck: passed.
npm run test:extension-host: 10 integration scenarios passed in installed VS Code 1.131.0, using a temporary profile/workspace. Real document, diff, workspace-edit, save, and local npm APIs were exercised; model responses and approval choices were test doubles.Integration scenarios cover original-target application after editor switching, stale documents, late results after cancellation, multi-file conflicts, cancelling review, approved two-file patch/save/test/result feedback, denied commands, package.json changes during approval, preservation of existing user edits, and path aliases.
Changed-file credential/artifact scan found no credentials, temporary logs, dependency trees, or generated bundles to commit.
Current limits
Draft for review; no merge, deployment, or release is requested.