Skip to content

The MSRV is 1.90, which is what the tree-sitter the parser wants requires - #155

Merged
HackingGate merged 2 commits into
mainfrom
msrv-1-90
Sep 9, 2026
Merged

The MSRV is 1.90, which is what the tree-sitter the parser wants requires#155
HackingGate merged 2 commits into
mainfrom
msrv-1-90

Conversation

@HackingGate

@HackingGate HackingGate commented Sep 9, 2026

Copy link
Copy Markdown
Owner

Raises the floor so #151 can land.

tree-sitter 0.27.0 and tree-sitter-language 0.1.8 declare rust-version = "1.90", and the MSRV job refuses them on a floor of 1.88:

error: rustc 1.88.0 is not supported by the following packages:
  tree-sitter@0.27.0          requires rustc 1.90
  tree-sitter-language@0.1.8  requires rustc 1.90

That job is not a lint. It compiles the crate on the version Cargo.toml declares rather than on whatever stable is that week, which is the whole reason the number is worth writing down -- so raising it is a claim CI checks rather than one it takes on trust.

Raising the floor is a decision about who can build uphold, not a dependency bump, so it is its own commit rather than a line inside dependabot's.

Both copies move together

Cargo.toml's rust-version and toolchain.toml's rustc want. Cargo cannot read the preflight's manifest and the preflight cannot read cargo's, which is the only reason the number exists twice; tests/test_toolchain.py refuses a tree where one moved without the other, and it passes here.

Verified on the floor, not on stable

$ cargo +1.90 check --locked --all-targets     # this tree
Finished `dev` profile

$ # with #151's Cargo.toml and Cargo.lock applied on top:
$ cargo +1.90 check --all-targets
Compiling tree-sitter-language v0.1.8
Compiling tree-sitter v0.27.0
Finished `dev` profile

$ cargo test                                    # with tree-sitter 0.27
807 passed, 0 failed

So 1.90 is the number that lets #151 through, and not a round one chosen above it. The tree-sitter grammars this crate embeds parse the same on 0.27 as on 0.26 -- the suite covers the comment-kind distinctions that depend on them, and none moved.

cargo fmt --check, cargo clippy --all-targets -- -D warnings, cargo run -- scan and the suite are clean on stable too.

https://claude.ai/code/session_01HertdiAvdNKGyjR91jvRUM

Summary by CodeRabbit

  • Chores
    • Raised the minimum supported Rust version to 1.90.
    • Updated the development toolchain requirement to Rust 1.90.

…ires

tree-sitter 0.27.0 and tree-sitter-language 0.1.8 declare rustc 1.90, so the
MSRV job refuses #151 on a floor of 1.88 -- not as a lint but as a build: the
job compiles the crate on the declared version rather than on whatever stable
is that week, which is the whole reason the number is checkable.

Raising the floor is the decision, and it is a decision about who can build
uphold rather than a dependency bump, so it is its own commit. Both copies move
together -- Cargo.toml's `rust-version` and toolchain.toml's rustc `want` --
because cargo cannot read the preflight's manifest and tests/test_toolchain.py
refuses a tree where only one of them moved.

Verified on the floor itself rather than on stable: `cargo +1.90 check --locked
--all-targets` builds this tree, and with #151's manifest and lock applied on
top it builds tree-sitter 0.27.0 and tree-sitter-language 0.1.8 too, with the
suite at 807 passed and 0 failed. So the number here is the number that lets
#151 through, and not a round one chosen above it.

Claude-Session: https://claude.ai/code/session_01HertdiAvdNKGyjR91jvRUM
@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 040c922f-680b-4913-9d2f-87230d9200b7

📥 Commits

Reviewing files that changed from the base of the PR and between 9359012 and bbac958.

📒 Files selected for processing (2)
  • Cargo.toml
  • toolchain.toml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The crate's minimum supported Rust version changes from 1.88 to 1.90. The package manifest comment now cites the dependency requirements, and the toolchain compiler constraint matches the new version.

Changes

Rust MSRV alignment

Layer / File(s) Summary
Update Rust version floor
Cargo.toml, toolchain.toml
The package requires Rust 1.90. The manifest comment identifies the dependency floors, and the toolchain requires rustc >=1.90.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to bbac9

The project now requires Rust 1.90 consistently across package metadata and toolchain configuration. No current merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title identifies the main change: raising the MSRV to 1.90 for tree-sitter compatibility. The wording is grammatically awkward but remains specific and related to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch msrv-1-90

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@HackingGate
HackingGate merged commit 8955289 into main Sep 9, 2026
12 checks passed
@HackingGate
HackingGate deleted the msrv-1-90 branch September 9, 2026 15:08
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.30%. Comparing base (9359012) to head (bbac958).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
+ Coverage   93.26%   93.30%   +0.03%     
==========================================
  Files          38       38              
  Lines       15276    15276              
==========================================
+ Hits        14247    14253       +6     
+ Misses       1029     1023       -6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants