The MSRV is 1.90, which is what the tree-sitter the parser wants requires - #155
Conversation
…ires tree-sitter 0.27.0 and tree-sitter-language 0.1.8 declare rustc 1.90, so the MSRV job refuses #151 on a floor of 1.88 -- not as a lint but as a build: the job compiles the crate on the declared version rather than on whatever stable is that week, which is the whole reason the number is checkable. Raising the floor is the decision, and it is a decision about who can build uphold rather than a dependency bump, so it is its own commit. Both copies move together -- Cargo.toml's `rust-version` and toolchain.toml's rustc `want` -- because cargo cannot read the preflight's manifest and tests/test_toolchain.py refuses a tree where only one of them moved. Verified on the floor itself rather than on stable: `cargo +1.90 check --locked --all-targets` builds this tree, and with #151's manifest and lock applied on top it builds tree-sitter 0.27.0 and tree-sitter-language 0.1.8 too, with the suite at 807 passed and 0 failed. So the number here is the number that lets #151 through, and not a round one chosen above it. Claude-Session: https://claude.ai/code/session_01HertdiAvdNKGyjR91jvRUM
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe crate's minimum supported Rust version changes from 1.88 to 1.90. The package manifest comment now cites the dependency requirements, and the toolchain compiler constraint matches the new version. ChangesRust MSRV alignment
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The project now requires Rust 1.90 consistently across package metadata and toolchain configuration. No current merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #155 +/- ##
==========================================
+ Coverage 93.26% 93.30% +0.03%
==========================================
Files 38 38
Lines 15276 15276
==========================================
+ Hits 14247 14253 +6
+ Misses 1029 1023 -6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Raises the floor so #151 can land.
tree-sitter 0.27.0andtree-sitter-language 0.1.8declarerust-version = "1.90", and the MSRV job refuses them on a floor of 1.88:That job is not a lint. It compiles the crate on the version Cargo.toml declares rather than on whatever
stableis that week, which is the whole reason the number is worth writing down -- so raising it is a claim CI checks rather than one it takes on trust.Raising the floor is a decision about who can build uphold, not a dependency bump, so it is its own commit rather than a line inside dependabot's.
Both copies move together
Cargo.toml'srust-versionandtoolchain.toml's rustcwant. Cargo cannot read the preflight's manifest and the preflight cannot read cargo's, which is the only reason the number exists twice;tests/test_toolchain.pyrefuses a tree where one moved without the other, and it passes here.Verified on the floor, not on stable
So 1.90 is the number that lets #151 through, and not a round one chosen above it. The tree-sitter grammars this crate embeds parse the same on 0.27 as on 0.26 -- the suite covers the comment-kind distinctions that depend on them, and none moved.
cargo fmt --check,cargo clippy --all-targets -- -D warnings,cargo run -- scanand the suite are clean on stable too.https://claude.ai/code/session_01HertdiAvdNKGyjR91jvRUM
Summary by CodeRabbit