Skip to content

06 - Get Code Review and Iterate #7

Description

@fgsumer

You should already have created a Pull Request (PR) for your Form Controls exercise.

Make sure you ask for review by adding the “Needs Review” label to the PR.

A volunteer will review it - you don’t need to ask, just adding the label is enough.

When the volunteer has reviewed it, they will either give you more suggestions (and add the “Reviewed” label), or tell you it’s perfect (and add the “Complete” label).

Until the volunteer says it is complete, you should keep making improvements - whenever you’re ready for more review, add the “Needs Review” label back.

If you’ve been waiting for review (whether initially, or after responding to comments) for more than a week, please ask for help on Slack in #code-review-itp. Do not ask for review until you’ve been waiting a week.

You also need to make sure you’re still working on your Wireframe to Web Code PR if it’s not already complete.

You will follow this same process for every PR you make at HYF. This is the last time we’ll make a issue to remind you.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions