Conversation
…/max values are involved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quantity intervals should have dimensionally compatible units. The current definitions for interval
StartandEndindicate that minimum or maximum point type values should be used for materializing null boundaries to their concrete representations. Since the minimum and maximum operators indicate that minimum/maximum Quantity values use the default unit ('1'), a strict reading ofStart/Endwould result in Quantity intervals with null boundaries returning those boundaries with unit'1'. This causes issues for other interval operators that are defined in terms ofStartandEndsince it could result in an interval's low and high boundaries having dimensionally incompatible units.This PR adjusts the language of the
StartandEndoperators to indicate that the Quantity value for a null boundary adopts the unit of the non-null boundary. As a bonus, this PR also updates the Interval definition to explicitly indicate the previously implied requirement for dimensionally compatible units and to also clarify that an interval's type can be derived from the high boundary when the low boundary is null.Fixes FHIR-57935.