Validation for returnable attributes in GET request

[mohankumaru]

Hi @GordonSo ,

I notice that there is no validation with respect to GET requests, like returnable , non-returnable or is supported already.

[GordonSo]

Hi @mohankumaru,

Currently, the library can only supports validating the schema itself for return (ensuring that the "return" properties are of documented types: always, never, default, request; and that supported is a boolean [this is specified in the serviceproviderconfig core schema]).

As per the library's description, it currently:

Validate SCIM Schema definition
Validate Model (schema) Id, Name, description, attributes
Validate Attribute (schema) Name, Type, Required, Canonical Values, Mutability, Returned, Uniqueness

Validate JSON Content against SCIM Schema
Validate significant value against Type (Binary, Boolean, Datetime, Decimal, Integer, Reference, String, Complex, MultiValued)
Characteristics Required, Canonical Values, Uniqueness

---

In order for the schema validate against the JSON data for "return"-able and supported, it is then necessary for the library to understand more context: whether the Json data parsed is a "request" or "response" body, and/or the operation method (GET, PUT, POST, PATCH) used; but we are currently not passing them in.

In order to do so, the library could be extended here and at the abstract attribute classes; once context-aware the attribute classes should already to have the necessary information to do the additional validations.

Would this make sense?

Upon future reading
I suppose the "default" and "supported" method applies specifically to "serviceproviderconfig" where the operations are specified. We don't currently have a use-case for that in our projects, so are open to ideas/ PRs how it will be called or extended.

[mohankumaru]

Thank you for your response @GordonSo . I understand what you're saying. I should probably put some thought on how to go about extending it.