Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Malformed schemas can still crash validation, and resource selection bypasses subtype-specific metadata behavior.
Review effort: Balanced
Findings: 3
Open (4)
What changed in this PR
Adds metadata schema validation tooling and fixes schema-generation defects found during validation.
Changes:
- Adds filtered JSON/CSV metadata validation with documented exit codes.
- Handles nullable
oneOffields and localized thesaurus fallbacks. - Enforces mandatory thesauri and adds command/handler tests.
| File | Description |
|---|---|
geonode/metadata/management/__init__.py |
Defines the management package. |
geonode/metadata/management/commands/__init__.py |
Defines the commands package. |
geonode/metadata/management/commands/validate_metadata.py |
Implements metadata validation and reporting. |
geonode/metadata/schemas/base.json |
Makes optional metadata fields nullable. |
geonode/metadata/handlers/abstract.py |
Adds shared nullable oneOf handling. |
geonode/metadata/handlers/base.py |
Applies null options to enumerated fields. |
geonode/metadata/handlers/sparse.py |
Adds label fallback and nullable choices. |
geonode/metadata/handlers/thesaurus.py |
Enforces mandatory thesaurus selections. |
geonode/metadata/tests/test_handlers.py |
Tests required thesaurus schema behavior. |
geonode/metadata/tests/test_validate_metadata.py |
Tests command selection, reports, and exits. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+203
to
+204
| self.schema = schema | ||
| self.required_fields = set(schema.get("required", [])) |
| return json.loads(json.dumps(data, cls=JSONEncoder)) | ||
|
|
||
| def select_resources(self, ids, resource_types): | ||
| queryset = ResourceBase.objects.all() |
| # GeoNode injects this key in the instance for testing purposes only (resources titled "*error*") | ||
| instance.pop("extraErrors", None) | ||
|
|
||
| errors = self.drop_redundant(validator.iter_errors(instance)) |
Comment on lines
+199
to
+203
| if oneof is None or not MetadataHandler._is_nullable(subschema): # an empty one is to be filled in | ||
| return | ||
|
|
||
| if not any("const" in option and option["const"] is None for option in oneof): | ||
| oneof.insert(0, {"const": None, "title": "-"}) # not "": the client turns it into None |
7 of 8 tasks
mattiagiupponi
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For details see the related PR on 5.1.x: #14679
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.