Repository navigation
[Fixes #14673]: Upload fails with duplicate key value violates unique constraint when column names start with a digit - #14677
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prefixed the name with
_instead of substituting inside it, and do it after slugify so the underscore isn't stripped:3_1a → _3_1a, 6_1a → _6_1a: distinct names, nothing deleted. The function is now also idempotent means under certain cirumstances it is currently possible that this function get called multiple times. Result now stays the same
Behaviour change
fixup_name() is used for layer/table names as well, so a layer named
1layernamenow normalises to_1layernameinstead of all appearances of the the first digit in a layername get replaced by_.closes #14673
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.