Skip to content

[Fixes #14659] Error in uploaded metadata in multilang instances - #14669

Merged
etj merged 1 commit into
masterfrom
14659_multilang_metadata
Sep 28, 2026
Merged

etj merged 1 commit into
masterfrom
14659_multilang_metadata

Conversation

@etj

@etj etj commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Forward porting of #14668

(cherry picked from commit 041e525)

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@etj
etj requested a review from mattiagiupponi September 28, 2026 14:29
@etj etj self-assigned this Sep 28, 2026
Copilot AI lite review requested due to automatic review settings September 28, 2026 14:29
@cla-bot cla-bot Bot added the cla-signed CLA Bot: community license agreement signed label Sep 28, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

No unresolved review comments remain, and approval assessments are unanimous.

Review effort: Lite
Findings: None

What changed in this PR

Fixes metadata loss during monolingual partial uploads in multilingual GeoNode instances.

Changes:

  • Preserves base-field values as the default-language translation.
  • Adds regression tests for multilingual-aware and unaware updates.
File Description
geonode/​metadata/​tests/​test_multilang.py Adds regression coverage for partial metadata updates.
geonode/​metadata/​handlers/​multilang.py Updates multilingual deserialization behavior.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@etj
etj merged commit a2b2780 into master Sep 28, 2026
17 checks passed
@etj
etj deleted the 14659_multilang_metadata branch September 28, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants