Repository navigation
Conversation
CallumNZ
reviewed
Oct 21, 2026
Comment on lines
+83
to
+84
| // PublishWithAttributesWithContext publishes message to topicArn with the supplied message attributes using ctx. | ||
| func (s *SNS) PublishWithAttributesWithContext(ctx context.Context, topicArn string, message []byte, messageAttributes map[string]types.MessageAttributeValue) error { |
Contributor
There was a problem hiding this comment.
the WithContext was a patch to not break existing code. Since PublishWithAttributes doesn't exist yet, might as well add ctx to that one.
Contributor
|
Need a test for each new method. |
CallumNZ
reviewed
Oct 21, 2026
| var m SNSMessage | ||
| err = json.Unmarshal([]byte(awsCmdReceiveMessage(testQueue)), &m) | ||
| require.Nil(t, err) | ||
| assert.Equal(t, testMessage, m.Message) |
Contributor
There was a problem hiding this comment.
would be good to do it like the S3 test, otherwise we don't know if the passed in context is being used:
kit/aws/s3/s3_integration_test.go
Line 400 in 4bc85b7
fix: changes per review
CallumNZ
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Resolves #.
Changes proposed in this pull request:
Production Changes
The following production changes are required to deploy these changes:
Review
Check the box that applies to this code review. If necessary please seek help with adding a checklist guide for the reviewer.
When assigning the code review please consider the expertise needed to review the changes.
Code Review Guide
Insert check list here if needed.