Repository navigation
TOUTL new sensor - #2853
Merged
Merged
TOUTL new sensor#2853
Conversation
gva6500
previously approved these changes
Oct 2, 2026
elidana
reviewed
Oct 2, 2026
elidana
left a comment
Contributor
There was a problem hiding this comment.
Hi @rumachan , thanks for that. I might have things mixed up, but based on the comments from @ricardojohansson in the field logs, I wonder if something need to be changed here?
- the serial number for the temperature sensor should be
415554? - the datalogger code was also updated, does it require a firmware file change to reflect this?
Contributor
Author
|
Yes you are right about the serial number @elidana . The field notes say but the equipment change information at the top of the ticket was not changed to reflect that. There is no mention of a firmware upgrade; it is not the same as a code update. According to Delta, firmware is and according today's data file I will make the required change to the serial number. |
gva6500
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new sensor added after a period without one connected. Old one was removed several months ago, and recorded then.