Repository navigation
fix(build): tidy obsolete module checksums - #1700
Conversation
Remove unused checksums with Go 1.25.10 so the release tidiness guard passes without changing resolved dependency versions. Closes Gentleman-Programming#1699
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2d4a150
Fleet review (qwen)Closes #1699. Fix: tidy obsolete module checksums. go.sum contained 14 obsolete golang.org/x checksums blocking v3.2.0 release workflow. Removed obsolete entries only. go mod tidy -diff passes. 0 new behavior/test. Suggestion (1)
Verdict: clean |
🔗 Linked Issue
Closes #1699
🏷️ PR Type
type:bug— Bug fixtype:feature— New featuretype:question— Question requiring tracked worktype:docs— Documentation onlytype:refactor— Code refactoringtype:chore— Maintenancetype:breaking-change— Breaking change📝 Summary
go mod tidy -diffwithout changinggo.mod, resolved dependency versions, runtime code, or the release guard.📂 Changes
go.sum🧪 Test Plan
go mod tidy -diff— RED exit1 before tidy, GREEN exit0/no diff afterward.go list -m allbefore/after — identical module graph;git diff -- go.modempty.go mod verify— all modules verified.git diff --check— pass; candidate is one file, 0 additions/14 deletions.CGO_ENABLED=0 go build -o .release-tools/engram.exe -ldflags='-X main.version=3.2.1' ./cmd/engramwith Go 1.25.10 — pass.review-bf1e5cf27864f6e6approved and acknowledged for exact tree04375400d24f8eecb6175dc1b8d0661a65849c5f.🤖 Automated Checks
Required issue-reference, approved-issue, type-label, Unit Tests, E2E Tests, and Plugin Tests: pending until GitHub runs them. Applicable lint, Windows, and transient-artifact checks are also pending.
✅ Contributor Checklist
type:*label.go.sumenters this PR; cache, binary, local ODD tracking, and unrelated changes excluded.💬 Notes for Reviewers
Release failure: https://github.com/Gentleman-Programming/engram/actions/runs/37561305090
Cloud v3.2.0 publication succeeded separately; this PR does not re-tag, bypass guards, publish npm, or merge automatically. A new v3.2.1 tag is planned only after explicit merge approval and successful merged-candidate checks.
Native acknowledgement succeeded; its optional candidate-view cleanup was deferred with
candidate-view-git-failure. No out-of-band cleanup or new review was attempted.