Add Payment Method Discounts - #21
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for restricting discounts to specific payment methods by extending the discount schema/types and introducing a new form section used on both the “Add Discount” and “Edit Discount” pages.
Changes:
- Introduced a new
DiscountPaymentMethodsclient component that toggles selected payment methods viareact-hook-form. - Extended discount schema/type surface area to include
paymentMethods(schema validation + backendDiscounttype). - Wired the new section into both add/edit discount pages and exported it from the discounts barrel.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/discounts/index.ts | Exposes the new payment-methods section via the discounts barrel export. |
| src/components/discounts/DiscountPaymentMethods.tsx | Adds the UI + form wiring for selecting payment methods. |
| src/components/discounts/DiscountForm.tsx | Maps discount.paymentMethods into the form schema for edit flows. |
| src/app/(hydration)/(base)/discounts/add/page.tsx | Renders the payment-methods section on the add discount page. |
| src/app/(hydration)/(base)/discounts/[id]/page.tsx | Renders the payment-methods section on the edit discount page. |
| src/api/backend/types.ts | Adds paymentMethods to the Discount response type. |
| src/api/backend/schemas/discounts/discountSchema.ts | Adds paymentMethods to the DiscountSchema zod schema. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.