Repository navigation
feat(web-ui): refine global search and confirmation dialogs - #3650
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refine Global Search with a 744 × 460 dialog, a separate frosted material layer, and responsive cards for actions, settings, features, projects and assistants. Prioritize actions, settings and features ahead of conversation and file results; keep content matches in lists.
Streamline session-deletion confirmation copy in all three locales and remove the path preview from related-directory removal confirmations. Add the shared strong-blur token and refresh generated theme projections.
Type and Areas
UI/UX / tests / docs. Web UI, design tokens and theme, generated Desktop and Data Tools CSS.
Motivation / Impact
Application controls become easier to find, while the search dialog keeps its glass material separate from animated content. Opaque fallbacks remain available for high contrast, reduced transparency and forced colors. Destructive actions retain their existing confirmation and ownership checks.
Verification
Passed locally:
pnpm run design-system:checkpnpm run check:web— includes type checking, Appearance contracts, all 28 color-governance surfaces and theme visual contracts.pnpm run i18n:audit— zero warnings.pnpm run motion:audit— intent inventory reviewed; no duplicate global keyframes.pnpm --dir src/web-ui run test:run src/app/global-search src/shared/ui/OverlayStack.test.tsx src/shared/ui/Dialog.test.tsx src/app/components/NavPanel/sections/sessions/sessionActionConfirmation.test.ts src/app/scenes/project-resources/useProjectDirectoryActions.test.tsx— 15 files, 129 tests passed.pnpm run data-tools:theme:checknode scripts/generate-startup-appearance-bootstrap.mjs --checkgit diff --check origin/main...HEADnode scripts/check-git-object-sizes.mjs --base origin/main --head HEAD— 19 blobs checked.Reviewer Notes
AI-assisted; locally tested with package, DOM and static contract checks. Browser/computer control and native visual verification were not performed, per the requested workflow.
Remote coverage uses simulated SSH/Peer surfaces and device-switch fixtures. No live Remote Workspace, Remote Control, Peer Device or Detached Dispatch environment was exercised. This change introduces no persistence or wire-format changes.
Based on refreshed
mainat6b0e6f83c, after #3649 merged. Reviewed open PRs, including #3495: its session-menu preferences touch the same confirmation handler/test but do not implement these presentation changes.Checklist