Model%prescribed_bcs_enabled (src/SELF_Model.f90:107) is read nowhere in src/, in any of the CPU, gpu, or apu variants.
Its three reads — one each in SELF_DGModel1D_t, SELF_DGModel2D_t, SELF_DGModel3D_t — were removed by 3fa444f (#121, "Add extensible boundary condition system") when the boundary-condition registry replaced hardcoded BC dispatch. The declaration was not.
It is still written in ~40 files under examples/ and test/, and still documented as a working performance knob:
docs/Models/linear-euler-2d-model.md:231docs/Models/linear-euler-3d-model.md:219
Both say setting it .false. "can improve the time-to-solution for your simulation by avoiding unnecessary host-device memory movement." It has no effect.
Downstream cost: a user writing a prescribed BC against the registry finds a flag named for exactly that feature, defaulting .true., documented as live, and reasonably concludes it gates their BC.
Suggested: remove the declaration and the examples//test/ assignments, and drop the two doc paragraphs. If it is instead meant to come back as a registry-aware optimisation, a comment on the declaration saying so would be enough.
Model%prescribed_bcs_enabled(src/SELF_Model.f90:107) is read nowhere insrc/, in any of the CPU,gpu, orapuvariants.Its three reads — one each in
SELF_DGModel1D_t,SELF_DGModel2D_t,SELF_DGModel3D_t— were removed by 3fa444f (#121, "Add extensible boundary condition system") when the boundary-condition registry replaced hardcoded BC dispatch. The declaration was not.It is still written in ~40 files under
examples/andtest/, and still documented as a working performance knob:docs/Models/linear-euler-2d-model.md:231docs/Models/linear-euler-3d-model.md:219Both say setting it
.false."can improve the time-to-solution for your simulation by avoiding unnecessary host-device memory movement." It has no effect.Downstream cost: a user writing a prescribed BC against the registry finds a flag named for exactly that feature, defaulting
.true., documented as live, and reasonably concludes it gates their BC.Suggested: remove the declaration and the
examples//test/assignments, and drop the two doc paragraphs. If it is instead meant to come back as a registry-aware optimisation, a comment on the declaration saying so would be enough.