Repository navigation
Put AnimationMotionPref/ThumbnailTypePref in Redux - #248
Merged
Merged
Conversation
This saves us costly IPC calls on each component render. Additionally, move the getters to invoke, so we can't slow down the world with `sendSync`.
CrystalSplitter
force-pushed
the
crystal/cache-prefs
branch
from
October 25, 2026 00:15
48f7bda to
30420b8
Compare
CrystalSplitter
changed the title
CrystalSplitter
marked this pull request as ready for review
October 25, 2026 00:16
CrystalSplitter
commented
Oct 25, 2026
Collaborator
|
I can test if needed :3 |
Collaborator
Author
|
Feel free. What this changes is the Animation/Thumb preference system. |
CrystalSplitter
force-pushed
the
crystal/cache-prefs
branch
from
October 25, 2026 05:16
ce89a27 to
1cf975b
Compare
Collaborator
|
Tested now, everything is fine n.n |
window.utils and window.settings calls are extremely slow, and we should avoid calling them if we have to. Most images are not animated. In theory, this should probably also be part of the redux state. However, this is annoying to thread. So let's just move this lower and we won't have to worry about it.
Collaborator
Author
|
Everything looks good on my end. Submitting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This saves us costly IPC calls on each component render.
Additionally, move the getters to invoke, so we can't slow
down the world with
sendSync.