Repository navigation
Match Languages/*.xaml with forward-slash paths on macOS/Linux; bump to 0.0.7 - #44
Merged
Merged
Conversation
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. 鈿欙笍 Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
馃煝 Approval recommended
The regex correctly supports both path separator styles without changing the intended file-matching scope.
0 open findings
What changed in this PR
Updates localization XAML discovery to support Windows and Unix-style paths.
Changes:
- Accepts both
\and/around theLanguagesdirectory. - Excludes either separator from language filenames.
| File | Description |
|---|---|
Flow.Launcher.Localization.Shared/鈥婥onstants.cs |
Makes language-file path matching cross-platform. |
馃 Review effort: Balanced
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
taooceros
changed the title
Jack251970
approved these changes
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LanguagesXamlRegexonly matched\Languages\<file>.xaml. On macOS/Linux, Roslyn passes additional files with/separators (e.g./Users/.../Plugins/Flow.Launcher.Plugin.Sys/Languages/en.xaml), so the source generator found no resource dictionaries and generated noLocalizeclass.Fix: accept either separator:
[\\/]Languages[\\/][^\\/]+\.xaml$.Verified on macOS (arm64, .NET 10) building
Flow.Launcher.Plugin.Sysfornet10.0from Flow.Launcher'savalonia-macbranch:CS0103: The name 'Localize' does not exist in the current contextNeeded for the macOS build in Flow-Launcher/Flow.Launcher#4705; that branch will need a release containing this fix.