Repository navigation
fix: support long GE setup prices and prompts - #106
Closed
AntonyGarand wants to merge 2 commits into
Closed
AntonyGarand wants to merge 2 commits into
AntonyGarand wants to merge 2 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
AntonyGarand
changed the base branch from
master
to
fix/plugin-hub-price-update
September 30, 2026 13:52
AntonyGarand
force-pushed
the
fix/ge-long-price-input
branch
from
September 30, 2026 13:53
8f418a8 to
4420ad6
Compare
Contributor
Author
|
Published to the Plugin Hub as 4420ad6 (runelite/plugin-hub#17412) and now merged into master via 33e9bd7. Closing as superseded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The max-cash update changed the GE price prompt and setup-price storage. The plugin still recognized only the quantity input mode and read the old 32-bit price field, leaving price buttons and hotkeys inactive and cash-stack quantity suggestions and chart prices stale or incorrect.
This patch starts from the currently published Plugin Hub commit,
a410537. The PR targetsfix/plugin-hub-price-update, which points to that release, so the fix can ship independently of the later changes onmaster.Summary
OfferEditor.isNumericInputModehelper, including hiding the offer chart during price entry.5753and refresh quantity suggestions and the chart when that varp changes.Validation
./gradlew clean build --no-daemon --console=plain— passed, 59 tests on the release baseline.git diff --check— passed.2,147,483,647.Agent session:
codex resume 01a0f278-f56c-7662-ab9f-d8400180b8ee· Model:gpt-6-astra· Reasoning:ultra🤖
cb-ship:created v1 skill@1.0.13