Skip to content

fix: support long GE setup prices and prompts - #106

Closed
AntonyGarand wants to merge 2 commits into
fix/plugin-hub-price-updatefrom
fix/ge-long-price-input
Closed

AntonyGarand wants to merge 2 commits into
fix/plugin-hub-price-updatefrom
fix/ge-long-price-input

Conversation

@AntonyGarand

@AntonyGarand AntonyGarand commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Why

The max-cash update changed the GE price prompt and setup-price storage. The plugin still recognized only the quantity input mode and read the old 32-bit price field, leaving price buttons and hotkeys inactive and cash-stack quantity suggestions and chart prices stale or incorrect.

This patch starts from the currently published Plugin Hub commit, a410537. The PR targets fix/plugin-hub-price-update, which points to that release, so the fix can ship independently of the later changes on master.

Summary

  • Recognize quantity and long-price prompts through the shared OfferEditor.isNumericInputMode helper, including hiding the offer chart during price entry.
  • Read setup prices as longs from varp 5753 and refresh quantity suggestions and the chart when that varp changes.
  • Add regression coverage for prompt activation/closure, unrelated prompts, and cash-stack quantities using ordinary, above-int-range, and unavailable prices.
  • Keep the release's packaging, CI configuration, and CSV behavior unchanged.

Validation

  • Java 11: ./gradlew clean build --no-daemon --console=plain — passed, 59 tests on the release baseline.
  • git diff --check — passed.
  • Compared against the Plugin Hub release: only the seven GE implementation/test files changed.
  • In-game testing pending: verify buy/sell price buttons and hotkeys, quantity entry, cash-stack suggestion refresh, and chart marker updates/visibility with ordinary prices and prices above 2,147,483,647.

Agent session: codex resume 01a0f278-f56c-7662-ab9f-d8400180b8ee · Model: gpt-6-astra · Reasoning: ultra

🤖 cb-ship:created v1 skill@1.0.13

@AntonyGarand AntonyGarand self-assigned this Sep 30, 2026
@coderabbitai

coderabbitai Bot commented Sep 30, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@AntonyGarand
AntonyGarand changed the base branch from master to fix/plugin-hub-price-update September 30, 2026 13:52
@AntonyGarand
AntonyGarand force-pushed the fix/ge-long-price-input branch from 8f418a8 to 4420ad6 Compare September 30, 2026 13:53
@AntonyGarand

Copy link
Copy Markdown
Contributor Author

Published to the Plugin Hub as 4420ad6 (runelite/plugin-hub#17412) and now merged into master via 33e9bd7. Closing as superseded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant