Skip to content

build: add standard Plugin Hub packaging and CI feedback - #103

Merged
AntonyGarand merged 1 commit into
masterfrom
build/standard-plugin-hub-ci
Sep 30, 2026
Merged

AntonyGarand merged 1 commit into
masterfrom
build/standard-plugin-hub-ci

Conversation

@AntonyGarand

@AntonyGarand AntonyGarand commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Why

Plugin Hub maintainers require build=standard for the review bot (discussion). Running the same packaging checks in this repository exposes build and API problems before a Hub submission.

This PR is rebased onto master at a410537468a84459f654304d9c9028d3e5ccb820, the latest accepted Plugin Hub revision. The restored published version uses JSON storage, so the previous SQLite compilation blocker is no longer present. The intended impact is earlier developer feedback; gameplay behavior is unchanged.

Summary

  • Select standard Hub packaging and set the displayed version in runelite-plugin.properties, retaining local Gradle development and test tasks.
  • Replace the Commons CSV runtime dependency with RuneLite-provided Commons Text escaping. Preserve CSV headers, comments, quoting, CRLF, Unicode, and long values.
  • Add independent Java 11 build/test and official RuneLite packager jobs for PRs, master pushes, and manual runs. The jobs check the actual PR head, use read-only permissions, and upload test reports, packaging logs, summaries, and successful JARs.
  • Verify the official v4 tooling checksum and use current Hub dependency/API metadata. Packaging runs in strict, nonpublishing PR mode, with failures retained as failed checks.

Validation

  • GitHub Actions run passed on rebased head 5de0019: Java 11 build/tests and official RuneLite Plugin Hub packaging both succeeded, with reports and package artifacts uploaded.
  • Java 11 ./gradlew clean build: 58 tests passed, zero failures or skips, including six CSV export tests.
  • Bash syntax, ShellCheck, and actionlint passed.
  • Rebase review confirmed the migration remains limited to the original eight files; the Gradle conflict was resolved without reintroducing SQLite.

To reproduce the Hub check on Linux with Java 11 after checking out this pushed branch:

PLUGIN_REPOSITORY=Flipping-Utilities/rl-plugin \
PLUGIN_COMMIT="$(git rev-parse HEAD)" \
  bash .github/scripts/check-plugin-hub.sh

Notes

The checks reproduce RuneLite's packaging feedback, not its separate review bot or maintainer approval. This PR does not update the Hub manifest or publish a plugin release.

Agent session: codex resume 01a0f008-f252-7760-9f1c-ae5973d6b587 · Model: gpt-6-astra · Reasoning: ultra

🤖 cb-ship:created v1 skill@1.0.13

@AntonyGarand AntonyGarand self-assigned this Sep 28, 2026
@coderabbitai

coderabbitai Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 4576077a-173d-4310-a5ef-8818274856b7

📥 Commits

Reviewing files that changed from the base of the PR and between a410537 and 5de0019.

📒 Files selected for processing (8)
  • .github/scripts/check-plugin-hub.sh
  • .github/scripts/plugin-hub-summary.py
  • .github/workflows/build.yml
  • README.md
  • build.gradle
  • runelite-plugin.properties
  • src/main/java/com/flippingutilities/db/TradePersister.java
  • src/test/java/com/flippingutilities/db/CsvExportTest.java
 _________________________________
< All your bugs are belong to us. >
 ---------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@AntonyGarand
AntonyGarand force-pushed the build/standard-plugin-hub-ci branch from d04e4e2 to 5de0019 Compare September 30, 2026 02:03
@AntonyGarand
AntonyGarand marked this pull request as ready for review September 30, 2026 02:14
@AntonyGarand
AntonyGarand merged commit 69aae30 into master Sep 30, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant