Repository navigation
fix(ci): give the Safari smoke 300 s to reach its 30 frames - #288
Merged
Merged
Conversation
Hosted macOS ARM runners render this page at ~1.6-2.2 FPS. At 1f563bf the smoke reached exactly 30 frames in its 120 s budget; at 9411f52 it reached 29 twice (run 41547950501), with no change to the code under test. Keep the 30-frame requirement and lengthen only the deadline; the wait loop exits as soon as the frames arrive.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 12 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. CodeRabbit Verify
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macOS ARM Live Test failed twice at
9411f52(41547950501) withSafari rendered 29 frames in 120 s (need 30). The page runs at about 1.6–2.2 FPS on hosted macOS ARM runners. The passing run at1f563bf(41540809896) reached exactly 30, and nothing under test changed between those commits.This keeps the 30-frame requirement and raises only the default
--ready-timeoutfrom 120 s to 300 s. The wait loop exits as soon as 30 frames arrive, so passing runs are no slower. The worst case adds 3 minutes, well inside the job's 40-minute limit.This test blocks the full-coverage evidence for the first Azure-signed release dry run.
Separately, the very low FPS and
canvas lit pixels=0in both the passing and failing runs may be worth their own investigation.