-
Notifications
You must be signed in to change notification settings - Fork 4
fix: serialize nested query dictionaries with bracket notation #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
7e7eec5
fix: serialize nested query dictionaries with bracket notation
javorosas 8f34115
feat(models): expose cursor and capped-total metadata on search results
javorosas 170043b
chore: bump to 6.9.0 (minor)
javorosas 67878a0
docs(changelog): add 6.9.0 entry
javorosas 509cb0b
fix(models): nullable page/totals + cover cursor and array serialization
javorosas 38be2c5
chore: release 7.0.0 (major) for nullable SearchResult totals
javorosas d684018
docs(changelog): drop duplicate 6.9.0 section (work released as 7.0.0)
javorosas 0b9a2fc
fix(router): repeat the key for list query params
javorosas 7062b76
fix(router): omit null query values instead of sending them empty
javorosas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,16 @@ | ||
| using System.Collections.Generic; | ||
| using System.Collections.Generic; | ||
|
|
||
| namespace Facturapi | ||
| { | ||
| public class SearchResult<T> | ||
| { | ||
| public int Page { get; set; } | ||
| public int TotalPages { get; set; } | ||
| public int TotalResults { get; set; } | ||
| // Nullable: cursor responses after the first page omit page/totals. | ||
| public int? Page { get; set; } | ||
| public int? TotalPages { get; set; } | ||
| public int? TotalResults { get; set; } | ||
| public bool? TotalsAreCapped { get; set; } | ||
| public string NextCursor { get; set; } | ||
| public string PreviousCursor { get; set; } | ||
| public List<T> Data { get; set; } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.