fix: serialize nested query map values with bracket notation - #14
Merged
Merged
Conversation
A date range passed as a nested map (Map.of("date", Map.of("gte", ..., "lt",
...))) was stringified with Map.toString(), producing garbage like
date={gte=2026-01-01, lt=2026-02-01}. Recurse into Map values and expand them
into bracket keys (date[gte]=...&date[lt]=...), matching the v2 API contract.
Iterable/array values keep expanding to repeated keys.
Bump to 2.1.1 and add a regression test.
SearchResult gains totalsAreCapped, nextCursor, and previousCursor so callers can follow cursor pagination and detect capped totals once the capping wave is live (page totals capped; cursor mode returns totals only on the first page).
The nested query serialization fix is a patch, but the new cursor and capped-total fields on SearchResult are additive public API, so the release is a minor per semver, consistent with the node SDK bump.
SearchResult cursor/capped metadata under Added; nested query map serialization fix under Fixed.
javorosas
requested review from
raul-facturapi
and
a balanced review from Copilot
September 9, 2026 23:23
raul-facturapi
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cambios (2.2.0)
Added
SearchResultexpone cursor/capped metadata:totalsAreCapped,nextCursor,previousCursor(paginación por cursores y totales capeados).Fixed
Map→ notación de corchetesdate[gte]=...).Bump 2.2.0 (minor: campos nuevos aditivos). CHANGELOG incluye la sección
[2.2.0].