Skip to content

Revert benchmarking action - #1570

Merged
tsmbland merged 5 commits into
mainfrom
revert_benchmarking_action
Oct 28, 2026
Merged

tsmbland merged 5 commits into
mainfrom
revert_benchmarking_action

Conversation

@tsmbland

@tsmbland tsmbland commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Reverting the benchmarking action, as it was annoying and giving lots of false positives. For now we'll just have to do benchmarking manually/locally, as described in the docs

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change to fix an issue)
  • New feature (non-breaking change to add functionality)
  • Refactoring (non-breaking, non-functional change to improve maintainability)
  • Optimization (non-breaking change to speed up the code)
  • Breaking change (whatever its nature)
  • Documentation (improve or add documentation)

Key checklist

  • All tests pass: $ cargo test
  • The documentation builds and looks OK: $ cargo doc
  • Update release notes for the latest release if this PR adds a new feature or fixes a bug
    present in the previous release

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

…_push_main"

This reverts commit 849164f, reversing
changes made to 5e5c403.
…action_benchmarks"

This reverts commit ae3839d, reversing
changes made to 547dc47.
…de_benches_from_pre_commit"

This reverts commit d89071b, reversing
changes made to eb386e8.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the removal of automated benchmark checks in favor of the documented manual process.

No open issues 🎉

What changed in this PR

Removes automated benchmark checks from MUSE2’s CI workflow to avoid false-positive regression alerts, returning benchmarking to the documented manual/local process.

Changes:

  • Removes the benchmark job, regression alerts, and automated baseline-update pull requests.
  • Deletes the CI benchmark conversion script and stored results, and removes the baseline file’s pre-commit exclusion.
File Description
benches/​convert_criterion_output.py Deletes the Criterion-to-JSON converter used by CI.
benches/​benchmark-data.json Deletes the stored CI benchmark baseline.
.pre-commit-config.yaml Removes the deleted baseline file’s exclusion.
.github/​workflows/​cargo-test.yml Removes the benchmark job while retaining test and coverage steps.

Review effort: Balanced

@tsmbland
tsmbland marked this pull request as ready for review October 28, 2026 10:27
@codecov

codecov Bot commented Oct 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.88%. Comparing base (1612d17) to head (73332ec).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1570   +/-   ##
=======================================
  Coverage   90.88%   90.88%           
=======================================
  Files          61       61           
  Lines        9121     9121           
  Branches     9121     9121           
=======================================
  Hits         8290     8290           
  Misses        509      509           
  Partials      322      322           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tsmbland
tsmbland merged commit 1b9a848 into main Oct 28, 2026
8 checks passed
@tsmbland
tsmbland deleted the revert_benchmarking_action branch October 28, 2026 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants