Repository navigation
Revert benchmarking action - #1570
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the removal of automated benchmark checks in favor of the documented manual process.
No open issues 🎉
What changed in this PR
Removes automated benchmark checks from MUSE2’s CI workflow to avoid false-positive regression alerts, returning benchmarking to the documented manual/local process.
Changes:
- Removes the benchmark job, regression alerts, and automated baseline-update pull requests.
- Deletes the CI benchmark conversion script and stored results, and removes the baseline file’s pre-commit exclusion.
| File | Description |
|---|---|
benches/convert_criterion_output.py |
Deletes the Criterion-to-JSON converter used by CI. |
benches/benchmark-data.json |
Deletes the stored CI benchmark baseline. |
.pre-commit-config.yaml |
Removes the deleted baseline file’s exclusion. |
.github/workflows/cargo-test.yml |
Removes the benchmark job while retaining test and coverage steps. |
Review effort: Balanced
tsmbland
marked this pull request as ready for review
October 28, 2026 10:27
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1570 +/- ##
=======================================
Coverage 90.88% 90.88%
=======================================
Files 61 61
Lines 9121 9121
Branches 9121 9121
=======================================
Hits 8290 8290
Misses 509 509
Partials 322 322 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reverting the benchmarking action, as it was annoying and giving lots of false positives. For now we'll just have to do benchmarking manually/locally, as described in the docs
Fixes # (issue)
Type of change
Key checklist
$ cargo test$ cargo docpresent in the previous release
Further checks