-
Notifications
You must be signed in to change notification settings - Fork 57
TSM-01: Add TS scaffolding, project-local ESLint, and CI alignment #557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Justin Hammond (Justintime50)
wants to merge
7
commits into
master
from
ts-migrate/01-ts-build-scaffolding
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4bc4914
TSM-01: add TS scaffolding and lint support
Justintime50 5e859c6
TSM-01: make eslint config project-local
Justintime50 c48160a
TSM-01: include CI workflow adjustments with lint scaffolding
Justintime50 d074a3a
ci(lint): ignore examples submodule paths
Justintime50 294ea8f
ci(lint): replace ignore symlinks with repo-local files
Justintime50 aa9c7c8
ci(format): replace prettier config symlink with file
Justintime50 5e75316
ci(scan): allowlist newly triaged npm advisories
Justintime50 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| dist | ||
| /docs | ||
| examples | ||
| node_modules | ||
| types/demo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| { | ||
| "extends": ["prettier", "eslint:recommended"], | ||
| "settings": { | ||
| "import/extensions": ["", ".js", ".ejs", ".json", ".yml", ".jsx"], | ||
| "import/ignore": [".ejs$", ".yml$", ".jsx", "node_modules"] | ||
| }, | ||
| "rules": { | ||
| "no-console": "off", | ||
| "import/no-unresolved": "off", | ||
| "no-param-reassign": "off", | ||
| "filenames/match-regex": "off", | ||
| "lines-between-class-members": "off", | ||
| "global-require": "off" | ||
| }, | ||
| "globals": { | ||
| "window": true, | ||
| "$": true | ||
| }, | ||
| "parserOptions": { | ||
| "ecmaVersion": 13, | ||
| "requireConfigFile": false, | ||
| "sourceType": "module" | ||
| }, | ||
| "env": { | ||
| "node": true, | ||
| "es6": true | ||
| }, | ||
| "overrides": [ | ||
| { | ||
| "files": ["**/*.ts"], | ||
| "parser": "@typescript-eslint/parser", | ||
| "plugins": ["@typescript-eslint"], | ||
| "parserOptions": { | ||
| "ecmaVersion": 2022, | ||
| "sourceType": "module" | ||
| }, | ||
| "rules": { | ||
| "no-undef": "off" | ||
| } | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,7 +15,6 @@ docs | |
| Icon | ||
| node_modules | ||
| npm-debug.log | ||
| /.eslintrc | ||
| /.eslintignore | ||
| /.prettierrc.yml | ||
| /.prettierignore | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| .golangci.yml | ||
| .mypy_cache | ||
| .nyc_output | ||
| cassettes | ||
| composer.json | ||
| composer.lock | ||
| coverage | ||
| dist/ | ||
| /docs | ||
| examples | ||
| official/fixtures/ | ||
| package-lock.json | ||
| style_guides/ | ||
| vendor/ | ||
| venv/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| trailingComma: all | ||
| singleQuote: true | ||
| printWidth: 100 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "compilerOptions": { | ||
| "target": "es5", | ||
| "module": "nodenext", | ||
| "strict": true, | ||
| "ignoreDeprecations": "5.0", | ||
| "esModuleInterop": true, | ||
| "forceConsistentCasingInFileNames": true, | ||
| "skipLibCheck": true | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "extends": "./tsconfig.base.json", | ||
| "compilerOptions": { | ||
| "allowJs": true, | ||
| "checkJs": false, | ||
| "declaration": true, | ||
| "noEmit": true | ||
| }, | ||
| "include": ["src/**/*.js", "src/**/*.ts", "test/**/*.js", "test/**/*.ts"], | ||
| "exclude": ["dist/**", "docs/**", "coverage/**", "node_modules/**"] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,7 @@ | ||
| { | ||
| "extends": "./tsconfig.base.json", | ||
| "compilerOptions": { | ||
| "target": "es5", | ||
| "module": "nodenext", | ||
| "strict": true, | ||
| "noEmit": true, | ||
| "esModuleInterop": true, | ||
| "forceConsistentCasingInFileNames": true | ||
| "noEmit": true | ||
| }, | ||
| "include": ["types"] | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question:
Does the eslintignore not cover examples?