Update obs4MIPs tables - #3194
Open
schlunma wants to merge 6 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3194 +/- ##
==========================================
- Coverage 96.49% 96.48% -0.01%
==========================================
Files 280 280
Lines 16282 16294 +12
==========================================
+ Hits 15711 15722 +11
- Misses 571 572 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
valeriupredoi
left a comment
Contributor
There was a problem hiding this comment.
this is mega, very many thanks, Manu! Ping me when you ready for a review 🍺
schlunma
marked this pull request as ready for review
August 12, 2026 13:51
Contributor
Author
|
This is ready now from my side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I've been working with obs4MIPs data a lot recently, which can be quite frustrating because our tables are very outdated. This PR updates the tables to the most recent commit (note that the latest released version is also very old (>3.5 years)).
Couple of additional things I found:
institutefacet for obs4MIPs data.gridfor obs4MIPs datasets to fully describe them (it works without it because in 99% of cases the grid isgn, but technically we need it). We might consider updating our recipes accordingly.Backwards-incompatible change #
Removal of tables
The following tables have been removed:
obs4MIPs_monNobs.json(with single variablendviNobs)obs4MIPs_monStderr.json: (with single variablendviStderr)Those cannot be used anymore.
Closes #1890
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
🛠 Changes are backward compatibleTo help with the number pull requests: