Skip to content

Update obs4MIPs tables - #3194

Open
schlunma wants to merge 6 commits into
mainfrom
update_obs4mips_tables
Open

Update obs4MIPs tables#3194
schlunma wants to merge 6 commits into
mainfrom
update_obs4mips_tables

Conversation

@schlunma

@schlunma schlunma commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Description

I've been working with obs4MIPs data a lot recently, which can be quite frustrating because our tables are very outdated. This PR updates the tables to the most recent commit (note that the latest released version is also very old (>3.5 years)).

Couple of additional things I found:

  • This also fixes the automatic retrieval of the institute facet for obs4MIPs data.
  • As far as I can tell from Metagrid, it's also necessary to specify a grid for obs4MIPs datasets to fully describe them (it works without it because in 99% of cases the grid is gn, but technically we need it). We might consider updating our recipes accordingly.

Backwards-incompatible change #

Removal of tables

The following tables have been removed:

  • obs4MIPs_monNobs.json (with single variable ndviNobs)
  • obs4MIPs_monStderr.json: (with single variable ndviStderr)

Those cannot be used anymore.

Closes #1890


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@schlunma schlunma added this to the v2.16.0 milestone Aug 11, 2026
@schlunma schlunma self-assigned this Aug 11, 2026
@schlunma schlunma added the cmor Related to the CMOR standard label Aug 11, 2026
@schlunma schlunma removed their assignment Aug 11, 2026
@codecov

codecov Bot commented Aug 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.48%. Comparing base (6f03e55) to head (a9cc626).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3194      +/-   ##
==========================================
- Coverage   96.49%   96.48%   -0.01%     
==========================================
  Files         280      280              
  Lines       16282    16294      +12     
==========================================
+ Hits        15711    15722      +11     
- Misses        571      572       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@valeriupredoi valeriupredoi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is mega, very many thanks, Manu! Ping me when you ready for a review 🍺

@schlunma
schlunma marked this pull request as ready for review August 12, 2026 13:51
@schlunma

Copy link
Copy Markdown
Contributor Author

This is ready now from my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backwards incompatible change cmor Related to the CMOR standard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

obs4MIPs CMOR tables could use an update

2 participants