Repository navigation
perf(platform): a published release reaches Flagger within a minute - #2514
Merged
Merged
Conversation
The image scans polled the registry every 5 minutes and the cluster fetched main every minute, so v1.24.1 took six minutes from announcement to Flagger. Both now run every 20s, and the scans list only v tags, so the sha- tags main pushes on every commit stay out of each scan. Part of #2513
Contributor
Changes
No production or test lines added. CoverageNo coverage summary reached this report. Patch coverage: this pull request changes no line that coverage measures.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2513
Why
v1.24.1 was announced at 16:47, but Flagger only picked it up at 16:53. Every step between the two is a poll:
flux-systemGitRepository fetches mainThe worst case falls from about 6 minutes to about 45s, and it is usually 20 to 30s.
What changes
exclusionList: ['^[^v]'], so only release tags are listed. Main pushes asha-tag on every commit, and each scan would otherwise list them all.flux-systemGitRepository ingotk-sync.yamlfetches every 20s. Runningflux bootstrapagain would reset this value, so it has to be kept if that ever happens.Cost
Considered instead
A Flux Receiver that
release.ymlcalls once the images are published, authenticated with GitHub's OIDC token. It would save about another 20s, but it needs a public webhook endpoint into Flux, so it was left out.