Conversation
fabnemEPFL
requested changes
Sep 24, 2026
Collaborator
There was a problem hiding this comment.
the failure of the job should be only in API mode, it should fail with just a logged warning in general. it would also be nice to make the job failure specify the exception
| batch_results.append(result) | ||
| except Exception as e: | ||
| logging.error(f"Failed to process {file}: {str(e)}") | ||
| batch_results.append(None) # handle partial failures |
Collaborator
There was a problem hiding this comment.
why remove this? it's a convenient way to save that there is no valid value for the failed file
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an invalid PDF was inserted into the index-api, it called the PDF processor's
process_batchmethod, which is an overload of theprocess_batchmethod from theProcessorclass. The method was catching the exception but not re-raising it, which caused the bug.A regression test has also been added to
tests/test_live_retriever_api.py.The new behaviour is now: