fix(security): validate and pin transcript request destinations - #125
Open
DoRmAmMu1997 wants to merge 1 commit into
Open
DoRmAmMu1997 wants to merge 1 commit into
DoRmAmMu1997 wants to merge 1 commit into
Conversation
Validate each redirect before fetching and pin the socket destination while preserving original TLS identity. Bound redirect traversal and avoid eager redirect-body reads. Document and test the fail-closed transport contract. Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transcript downloads previously followed redirects before checking the final destination. This change validates every hop before requesting it and connects to a validated public IP while retaining the original Host header, TLS SNI, and certificate hostname.
The transport refuses private/mixed DNS answers, malformed or looping redirects, more than three hops, ambient proxies/netrc settings, and unsupported legacy Session injection. Redirect bodies are not eagerly consumed; successful PDFs retain streamed size, content-type, and magic-byte checks. Trusted offline resolver/transport hooks support tests. The default application caller uses the hardened owned transport.
Direct urllib3 usage is declared and pinned to the already-tested 2.7.0 version. The ADR and component docs explain the destination boundary and compatibility change.
Validation:
PDF parser process containment is a separate work package. This PR changes the HTTP/download boundary only.
Co-authored by Codex.