Skip to content

Validate the requested image exists within the project #1665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpeel merged 1 commit into from
Oct 5, 2026
Merged

Validate the requested image exists within the project #1665

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions tools/project_manager/diff.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,19 +32,11 @@
}

$project = new Project($projectid);
// validate that the page exists within the project
$project->get_project_page($image);
$state = $project->state;
$project_title = $project->nameofwork;

if (!$project->pages_table_exists) {
// This shouldn't normally happen --
// if the page table doesn't exist, a "diff" link shouldn't be shown.
// But a user might have a bookmarked or otherwise saved a 'diff' URL.
echo "<p>", _("Page details are not available for this project."), "</p>\n";
echo "<p>", _("Project ID"), ": $projectid</p>\n";
echo "<p>", _("Title"), ": " . html_safe($project_title) . "</p>\n";
exit;
}

// --------------------------------------------------------------
// get information about this diff
$L_format = $L_round->id == "OCR" ? false : is_formatting_round($L_round);
Expand Down