Skip to content

project_quick_check.inc: Handle load_project_words failures #1660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpeel merged 1 commit into from
Sep 30, 2026
Merged

project_quick_check.inc: Handle load_project_words failures #1660

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 27 additions & 12 deletions pinc/project_quick_check.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,23 +643,38 @@ function tds_for_invalid_chars(string $raw): string

function _test_project_for_word_lists(string $projectid): PQCResult
{
$num_good_words = count(load_project_good_words($projectid));
$num_bad_words = count(load_project_bad_words($projectid));
$good_words = load_project_good_words($projectid);
$bad_words = load_project_bad_words($projectid);

$test_name = _("Good/Bad Wordlists");
$test_desc = _("This test checks if the project good and bad word lists are populated.");

$details = "<p><ul>";
$details .= "<li>" . _("Number of good words") . ": $num_good_words</li>";
$details .= "<li>" . _("Number of bad words") . ": $num_bad_words</li>";
$details .= "</ul></p>";

if ($num_good_words || $num_bad_words) {
$status = _("Success");
$summary = _("At least one of the good and bad word lists have entries.");
if (is_string($good_words) || is_string($bad_words)) {
$details = "<p><ul>";
if (is_string($good_words)) {
$details .= "<li>" . _("Error loading good words") . ": $good_words</li>";
}
if (is_string($bad_words)) {
$details .= "<li>" . _("Error loading bad words") . ": $bad_words</li>";
}
$details .= "</ul></p>";
$summary = _("Error loading word lists.");
Comment thread
cpeel marked this conversation as resolved.
$status = _("Error");
} else {
$status = _("Warning");
$summary = _("Both of the word lists are empty.");
$num_good_words = count($good_words);
$num_bad_words = count($bad_words);
$details = "<p><ul>";
$details .= "<li>" . _("Number of good words") . ": $num_good_words</li>";
$details .= "<li>" . _("Number of bad words") . ": $num_bad_words</li>";
$details .= "</ul></p>";

if ($num_good_words || $num_bad_words) {
$status = _("Success");
$summary = _("At least one of the good and bad word lists have entries.");
} else {
$status = _("Warning");
$summary = _("Both of the word lists are empty.");
}
}

return new PQCResult($test_name, $test_desc, $status, $summary, $details);
Expand Down