DPDatabase.inc: query() never returns false if $throws_exception == true - #1658
Merged
cpeel merged 1 commit intoSep 29, 2026
Merged
Conversation
Give more precise PHPStan type annotations which reveals issues with several callers. This removes `false` as a possible return value for several callers such as: - `ProjectSearchResults::get_sorting()` - `log_access_change()` - `get_latest_access_change_entry()` - `_run_pp_threshold_query_result()` This has knock-on effects for several callers which relied on `query()` returning false on a DB connection failure so it can do its own error handling, so add `throws_exception: false` to these calls: - `project_recalculate_page_counts()` - `DPSessionHandler::write()` - `DPSessionHandler::destroy()` - `page_info_query()` (cherry picked from commit 9e3d604905c96419adc5d89da27bae477943ada7)
cpeel
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Give more precise PHPStan type annotations which reveals issues with several callers.
This removes
falseas a possible return value for several callers such as:ProjectSearchResults::get_sorting()log_access_change()get_latest_access_change_entry()_run_pp_threshold_query_result()This has knock-on effects for several callers which relied on
query()returning false on a DB connection failure so it can do its own error handling, so addthrows_exception: falseto these calls:project_recalculate_page_counts()DPSessionHandler::write()DPSessionHandler::destroy()page_info_query()