page_table.inc: array_map/filter code cleanups - #1657
Merged
Merged
Conversation
cpeel
approved these changes
Sep 29, 2026
cpeel
left a comment
cpeel
left a comment
Member
There was a problem hiding this comment.
Tiny update to make it consistent with the other variables used in the anonymous functions.
While trying to understnad some of the code in page_table.inc, I saw a number of simplifications could be made and the comments/variable names could be improved a little. This should be functionally identical to before, but shorter, and (hopefully) the invariants should be a little more clear.
bpfoley
force-pushed
the
level-7-array-map
branch
from
September 29, 2026 21:57
a44527f to
02f8f95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying to understnad some of the code in page_table.inc, I saw a number of simplifications could be made and the comments/variable names could be improved a little.
This should be functionally identical to before, but shorter, and (hopefully) the invariants should be a little more clear.