Skip to content

ENG-2132 Add sortable columns to the relations table - #1295

Merged
mdroidian merged 2 commits into
mainfrom
codex/add-sortable-relations-table
Aug 16, 2026
Merged

ENG-2132 Add sortable columns to the relations table#1295
mdroidian merged 2 commits into
mainfrom
codex/add-sortable-relations-table

Conversation

@mdroidian

@mdroidian mdroidian commented Aug 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

https://www.loom.com/share/713ffebabfa34e088443f7981f71549d

Summary

  • Add sortable Source, Relation, and Destination columns to the Roam relations table
  • Support ascending, descending, and reset sorting states
  • Add accessible sort indicators and unit tests for sorting behavior

Testing

  • Added Vitest unit tests covering sort order, direction cycling, and immutability
  • Not run (not requested)
Open in Devin Review

@vercel

vercel Bot commented Aug 16, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
discourse-graph Skipped Skipped Aug 16, 2026 4:43am

Request Review

@supabase

supabase Bot commented Aug 16, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@mdroidian mdroidian changed the title Add sortable columns to the relations table ENG-2132 Add sortable columns to the relations table Aug 16, 2026
@linear-code

linear-code Bot commented Aug 16, 2026

Copy link
Copy Markdown

ENG-2132

devin-ai-integration[bot]
devin-ai-integration Bot reviewed Aug 16, 2026
View reviewed changes

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Open in Devin Review

Comment thread apps/roam/src/components/settings/DiscourseRelationConfigPanel.tsx
@mdroidian
mdroidian merged commit c8c9d82 into main Aug 16, 2026
8 checks passed
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Aug 16, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6ae43de8fd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/roam/src/utils/sortRelations.ts
@mdroidian
mdroidian deleted the codex/add-sortable-relations-table branch August 16, 2026 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments
@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mdroidian