Repository navigation
Fix/terrame ca equivalence - #20
Merged
Merged
Conversation
Parity.lua builds the neighborhood with wrap = true; libpysal's Rook cannot wrap, so the waves stopped at the grid edges. Add grid_neighbors(), which builds Von Neumann or Moore neighborhoods from the "row-col" index with optional wrap, and use it in Parity (setup(wrap=False) keeps the old grid). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Pz64hUFuJziQcwY2aRXQkz
The comment mapped TerraME (x, y) to "{y}-{x}", but the seeds were at row
15. They are now "25-20" and "25-30", consistent with Parity; the smallest
valid grid becomes 31 columns x 26 rows.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Pz64hUFuJziQcwY2aRXQkz
Growth.lua uses createNeighborhood{strategy = "vonneumann"}; the model used
Queen (8 neighbors), which grows a different cluster.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Pz64hUFuJziQcwY2aRXQkz
Fire.lua leaves each cell empty with probability 0.1 and sets one cell, drawn among all cells, burning. Add FireState.EMPTY = 3 and the empty parameter to the vector and raster models; initial_fire_density now defaults to 0.0 (single ignition) and, above zero, keeps the old random fraction of burning cells. Docs, the notebook and the Streamlit example show the fourth state with a fixed colour scale. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Pz64hUFuJziQcwY2aRXQkz
Parity and Excitable are compared step by step with a NumPy transcription of the Lua rules (the Parity test also checks that wrap matters); Growth and Fire are checked for neighborhood and initial state. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Pz64hUFuJziQcwY2aRXQkz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.