Skip to content

Updated docs theme colours and add reference to highlight and tertiary - #267

Open
zoharma wants to merge 2 commits into
mainfrom
zma/docs-ds-theme-colours-cleanup
Open

Updated docs theme colours and add reference to highlight and tertiary#267
zoharma wants to merge 2 commits into
mainfrom
zma/docs-ds-theme-colours-cleanup

Conversation

@zoharma

@zoharma zoharma commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Correct MUI role calls, regroup and introduce brand colours

  • Corrected mislabeled MUI palette calls in the Neutral colours reference (e.g. onSurfaceMutedtext.muted) to match the real roles in DiamondDSTheme.ts.
  • Split "Intent colours" into two groups: functional MUI-exposed roles (primary, secondary, info, danger, warning, success) and a new "Core brand colours" section (brand, tertiary, highlight). Only brand is still an actual MUI palette role.
  • Added a contrastText row to each intent/brand family, previously undocumented.

p.s. We can name Tertiary to something else like Brand Accent if we thing it would be helpful

@zoharma zoharma added the v0.6.3 label Jul 23, 2026
@zoharma
zoharma marked this pull request as ready for review July 23, 2026 13:21
Comment thread src/storybook/foundation/1.1. theme-colours.mdx Outdated
@zoharma
zoharma requested a review from a team August 13, 2026 16:35
@zoharma
zoharma force-pushed the zma/docs-ds-theme-colours-cleanup branch 3 times, most recently from 0416ab9 to c3f30c3 Compare August 13, 2026 16:56
@zoharma

zoharma commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

Followng @gfrn's comment, I found a few discrepancies that were fixed as part of this PR:

  • --ds-action-disabled was only used for disabled Checkbox/Radio icons, so rename it to --ds-control-disabled to better reflect its scope.
  • Document --ds-on-surface-disabled as backing both text.disabled and action.disabled
  • Document --ds-surface-disabled as action.disabledBackground
  • Fix the incorrect “On Surface Disabled” swatch
  • Show actual MUI palette paths on intent/brand swatches (for example, primary.main and error.main)
  • Rename “{role} Contrast Text” to “On {role}” for consistency

…bled-state docs

- `--ds-action-disabled` was only used for disabled Checkbox/Radio icons, so rename it to `--ds-control-disabled` to better reflect its scope.
- Document `--ds-on-surface-disabled` as backing both `text.disabled` and `action.disabled`
- Document `--ds-surface-disabled` as `action.disabledBackground`
- Fix the incorrect “On Surface Disabled” swatch
- Show actual MUI palette paths on intent/brand swatches (for example, `primary.main` and `error.main`)
- Rename “{role} Contrast Text” to “On {role}” for consistency
@zoharma
zoharma force-pushed the zma/docs-ds-theme-colours-cleanup branch from c3f30c3 to b746534 Compare August 13, 2026 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants