Updated docs theme colours and add reference to highlight and tertiary - #267
Open
zoharma wants to merge 2 commits into
Open
Updated docs theme colours and add reference to highlight and tertiary#267zoharma wants to merge 2 commits into
zoharma wants to merge 2 commits into
Conversation
gfrn
reviewed
Aug 13, 2026
zoharma
force-pushed
the
zma/docs-ds-theme-colours-cleanup
branch
3 times, most recently
from
August 13, 2026 16:56
0416ab9 to
c3f30c3
Compare
Contributor
Author
|
Followng @gfrn's comment, I found a few discrepancies that were fixed as part of this PR:
|
…bled-state docs
- `--ds-action-disabled` was only used for disabled Checkbox/Radio icons, so rename it to `--ds-control-disabled` to better reflect its scope.
- Document `--ds-on-surface-disabled` as backing both `text.disabled` and `action.disabled`
- Document `--ds-surface-disabled` as `action.disabledBackground`
- Fix the incorrect “On Surface Disabled” swatch
- Show actual MUI palette paths on intent/brand swatches (for example, `primary.main` and `error.main`)
- Rename “{role} Contrast Text” to “On {role}” for consistency
zoharma
force-pushed
the
zma/docs-ds-theme-colours-cleanup
branch
from
August 13, 2026 16:59
c3f30c3 to
b746534
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct MUI role calls, regroup and introduce brand colours
onSurfaceMuted→text.muted) to match the real roles in DiamondDSTheme.ts.p.s. We can name Tertiary to something else like Brand Accent if we thing it would be helpful