Remove trailing slash from policy_host in auth host endpoint - #290
Open
shree-iyengar-dls wants to merge 5 commits into
Open
Remove trailing slash from policy_host in auth host endpoint#290shree-iyengar-dls wants to merge 5 commits into
shree-iyengar-dls wants to merge 5 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #290 +/- ##
==========================================
+ Coverage 78.75% 79.34% +0.59%
==========================================
Files 13 13
Lines 2057 2116 +59
==========================================
+ Hits 1620 1679 +59
Misses 437 437 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
shree-iyengar-dls
changed the title
tpoliaw
previously approved these changes
Aug 13, 2026
tpoliaw
left a comment
tpoliaw
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. Is it worth trimming leading / on the policies as well?
Co-authored-by: Peter Holloway <peter.holloway@diamond.ac.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #245
Used trim_end_matches('/') to remove any trailing slashes