Repository navigation
WP11: support realization-aware separator fitting - #112
Merged
Merged
Conversation
IvanChernyshov
marked this pull request as ready for review
October 5, 2026 14:12
30 of 45 tasks
This was referenced Oct 5, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the approved WP11 workflow in #111: adds
pyvoro2.inverse.fit_self_consistent_weights_from_separatorswith the exact agreed signature and re-exports the identical existing result class. The thin facade forwards to the concrete active engine, translating onlymax_outer_iterinto existing options and selecting all candidates initially with history disabled.Final-state inspection is Provisional across both imports of the shared class. Advanced engine/configuration, history, paths, counters and path-derived labels remain Experimental. Fixed fitting, solver mathematics, report v2, native qualification and all 53 advanced exports retain their existing behavior.
Public tests cover all five outer outcomes with independent numerical/geometric oracles, 2D/3D and periodic routes, mixed and bounded policy, output availability, strict validation, exact source binding and certificate failure propagation. Current references and guides document the three separate outcomes: outer termination, final inner status and final-state availability. Factual planning updates record WP11 as a candidate pending independent acceptance.
Validation at final head
194500338b5a782420fb438a967c0fe9a7f721d4:Base/current
dev:dadbddb9fe3496d96a3606c6808c6084f8b7d687. Final root tree:2e3b762b51d3bdb6b7331f033d54d2bd3635480d. Canonical manifest SHA-256:e9ba7ad7be4c8a3c0a5121fb9ccda5ed0175ed53baa0be98cc89f20f32424965; aggregate source:7e2ba7ff2d38025d063f997a95ad4c8d1c96708d387e7ea19fc318c200e0e81c. Manifest refresh was explicit measure/update/check; no automatic refresh or qualification bypass was introduced. Earlier-head runs are historical.Implementation-side source review has no outstanding findings. Leave open for independent final review. Acceptance and integration remain maintainer decisions; this PR does not merge, close WP11, update #47 acceptance, accept Checkpoint C or start the later Phase C gate.