refactor(importers): track reimport finding buckets by id, not instance

[valentijnscholten]

Summary

Stacked on #15599. DefaultReImporter._process_findings_internal kept every
original/new/reactivated/unchanged Finding instance alive in memory for the
whole run, purely so notify_scan_added() and update_import_history() could
read a few scalar fields off them at the very end. On a large reimport that
pins the full result set in memory for no reason.

• original_items, new_items, reactivated_items, unchanged_items now
  hold ids, not instances.
• close_old_findings() and the JIRA finding-group push are the only
  consumers that need real rows; both now requery deliberately, in bounded
  chunks, at the point they need them -- and share self.test rather than
  each row carrying its own copy of the test -> engagement -> product
  chain, the same pattern reimport matching already uses.
• notify_scan_added() is rewritten to requery a capped, ordered slice
  (NOTIFICATION_SCAN_ADDED_MAX_FINDINGS, default 100) instead of templating
  every touched finding into a notification body.
• dojo.finding.helper.filter_findings_by_existence (instance-based, one
  caller) is replaced by filter_finding_ids_by_existence (id-based).

A pre-existing bug this surfaced (not introduced by this PR)

close_old_findings() used to receive self.to_mitigate as the original,
never-refreshed Finding instances fetched at the very start of the run.
process_matched_active_finding()'s two inline-closing branches (report
re-marks a matched, previously-active finding as mitigated, or as
risk-accepted/false-p/out-of-scope) never removed that finding from
to_mitigate's bucket arithmetic, so close_old_findings() picked it up
again and redundantly re-mitigated it using the stale, pre-reimport
instance -- silently overwriting fields like verified back to their
pre-reimport value, and only that redundant pass is what produced the
"closed" accounting entry and the "Mitigated by ... re-upload." note; the
inline branches themselves never wrote either.

This PR's honest re-hydrate (a fresh DB read instead of reusing the stale
instance) makes close_old_findings() correctly recognize the finding as
already mitigated and skip it -- which surfaced that skipping it also lost
the accounting entry, the note, and let the stale re-save's field-stomping
stop (a real, if obscure, improvement: a reimport's explicit verified=
override now actually sticks instead of being silently reverted).
Added self.actively_closed_matches tracking and an inline audit note so
both branches now do directly what the accidental double-processing used to
paper over. See the added commit for the full explanation, and
test_import_veracode_reimport_veracode_active_verified_mitigated's updated
assertions for what changed observably.

Test plan

• unittests.test_reimport_batch_flush -- updated assertions for the new
  id-based buckets, passes.
• unittests.test_importers_importer -- no new failures vs baseline
  (pre-existing 301-redirect failures in FlexibleImportTestAPI /
  FlexibleReimportTestAPI reproduce identically with this branch
  stashed out, confirmed unrelated).
• unittests.test_import_reimport -- full file green (256 assertions
  across test_import_reimport.py + neighboring importer test files
  combined), including the veracode double-processing fix above, found
  by running this file for the first time against the complete stack
  rather than assuming "zero behavior change" held everywhere.
• Full Pro importers/connectors suite (which exercises this OSS code via
  ProReImporter) -- 2391 passed, 119 skipped, 0 failed after fixing a
  local dev-stack env misconfiguration (DD_V3_FEATURE_LOCATIONS) that
  had produced 46 false failures unrelated to this change.
• Pro's test_importers_performance.py assertNumQueries baselines
  updated; the refactor is a net reduction in query count on every step
  except one that initially regressed by 21 queries (an N+1 from
  freshly-hydrated close_old_findings candidates not sharing
  self.test) -- fixed at the root rather than absorbed into the pinned
  count, which now shows a net decrease vs the pre-refactor baseline.
• OSS's own unittests.test_importers_performance re-pinned for the
  query-count shift from the veracode double-processing fix above (net
  -3 on the empty-report reimport step, from no longer redundantly
  re-processing an already-closed finding; +1-3 elsewhere from the new
  inline audit note).
• unittests/test_tag_inheritance_perf.py's reimport-with-new-findings
  baselines were hand-recomputed while rebasing onto a dev commit that
  independently changed the same constants (two additive deltas from a
  common ancestor, combined arithmetically: EXPECTED_ZAP_REIMPORT_WITH_NEW_V3
  193 -> 194). Could not run locally -- this dev stack's Pro integration
  permanently disables watson, which this test class's fixture needs.
  Flagging for CI to confirm.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.