Skip to content

fix(dedupe): give Checkmarx Scan detailed a hash_code field list #15580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devGregA wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

fix(dedupe): give Checkmarx Scan detailed a hash_code field list #15580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31b991c
fix(dedupe): give Checkmarx Scan detailed a hash_code field list
devGregA Aug 8, 2026
b86ce67
test(dedupe): refresh the Checkmarx Scan detailed fixture hash_codes
devGregA Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dojo/fixtures/dojo_testdata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1607,7 +1607,7 @@
"url": null,
"notes": [],
"dynamic_finding": false,
"hash_code": "9aca00affd340c4da02c934e7e3106a45c6ad0911da479daae421b3b28a2c1aa",
"hash_code": "bc912aacda3a8707cbf94b96e6350a5cc77e7ef4a29a1442cb1a041e4e1f38d8",
"last_reviewed": null
}
},
Expand Down Expand Up @@ -1655,7 +1655,7 @@
"url": null,
"notes": [],
"dynamic_finding": false,
"hash_code": "9aca00affd340c4da02c934e7e3106a45c6ad0911da479daae421b3b28a2c1aa",
"hash_code": "bc912aacda3a8707cbf94b96e6350a5cc77e7ef4a29a1442cb1a041e4e1f38d8",
"last_reviewed": null
}
},
Expand Down
4 changes: 2 additions & 2 deletions dojo/fixtures/dojo_testdata_locations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1632,7 +1632,7 @@
"url": null,
"notes": [],
"dynamic_finding": false,
"hash_code": "9aca00affd340c4da02c934e7e3106a45c6ad0911da479daae421b3b28a2c1aa",
"hash_code": "bc912aacda3a8707cbf94b96e6350a5cc77e7ef4a29a1442cb1a041e4e1f38d8",
"last_reviewed": null
}
},
Expand Down Expand Up @@ -1680,7 +1680,7 @@
"url": null,
"notes": [],
"dynamic_finding": false,
"hash_code": "9aca00affd340c4da02c934e7e3106a45c6ad0911da479daae421b3b28a2c1aa",
"hash_code": "bc912aacda3a8707cbf94b96e6350a5cc77e7ef4a29a1442cb1a041e4e1f38d8",
"last_reviewed": null
}
},
Expand Down
9 changes: 9 additions & 0 deletions dojo/settings/settings.dist.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1081,6 +1081,15 @@ def generate_url(scheme, double_slashes, user, password, host, port, path, param
"Burp Scan": ["title", "severity", "vuln_id_from_tool"],
"CargoAudit Scan": ["vulnerability_ids", "severity", "component_name", "component_version", "vuln_id_from_tool"],
"Checkmarx Scan": ["cwe", "severity", "file_path"],
# Same three fields as "Checkmarx CxFlow SAST" below, and for the same reason: the
# detailed mode of this parser sets vuln_id_from_tool (queryId), file_path (sinkFilename)
# and line (sinkLineNumber) on every finding, so all three are populated and none of them
# carries scan text. Without an entry here the scan type fell through to the legacy field
# set, which includes `description` -- so a parser change that reworded a finding moved its
# hash_code, which is the fragility this list exists to avoid. The algorithm for this scan
# type is unique_id_from_tool, so the change moves the stored hash without changing how
# candidates are looked up.
"Checkmarx Scan detailed": ["vuln_id_from_tool", "file_path", "line"],
"Checkmarx OSA": ["vulnerability_ids", "component_name"],
"Cloudsploit Scan": ["title", "description"],
"Coverity Scan JSON Report": ["title", "cwe", "line", "file_path", "description"],
Expand Down
4 changes: 2 additions & 2 deletions unittests/test_deduplication_logic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,8 @@
# engagement 5: April monthly engagement (dedupe_inside: True)
# test 55: Checkmarx Scan detailed (algo=unique_id_from_tool, dynamic=False)
# findings:
# 124 : "Low Impact Test Find": Low : act: True : ver: True : mit: False: dup: False: dup_id: None: hash_code: 9aca00affd340c4da02c934e7e3106a45c6ad0911da479daae421b3b28a2c1aa: eps: 0: notes: []: uid: 12345
# 125 : "Low Impact Test Find": Low : act: True : ver: True : mit: False: dup: True : dup_id: None: hash_code: 9aca00affd340c4da02c934e7e3106a45c6ad0911da479daae421b3b28a2c1aa: eps: 0: notes: []: uid: 12345
# 124 : "Low Impact Test Find": Low : act: True : ver: True : mit: False: dup: False: dup_id: None: hash_code: bc912aacda3a8707cbf94b96e6350a5cc77e7ef4a29a1442cb1a041e4e1f38d8: eps: 0: notes: []: uid: 12345
# 125 : "Low Impact Test Find": Low : act: True : ver: True : mit: False: dup: True : dup_id: None: hash_code: bc912aacda3a8707cbf94b96e6350a5cc77e7ef4a29a1442cb1a041e4e1f38d8: eps: 0: notes: []: uid: 12345
# endpoints
# 2: ftp://localhost/
# 1: http://127.0.0.1/endpoint/420/edit/
Expand Down
Loading