Skip to content

fix(ffe): accept dependent flag capability queries in mock backend - #8399

Open
hhan2024 wants to merge 2 commits into
mainfrom
codex/ffe-capability-query
Open

hhan2024 wants to merge 2 commits into
mainfrom
codex/ffe-capability-query

Conversation

@hhan2024

@hhan2024 hhan2024 commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Agentless clients advertising cap_dependent-flags-variant-key=v1 receive HTTP 404 from the mock backend because its environment check compares the entire query dictionary. This causes configuration-source tests to remain PROVIDER_NOT_READY despite valid requests.

Allow that capability parameter alongside the required dd_env=test, preserving rejection of missing, invalid, or repeated environment values. Parameterize the existing backend test to verify configuration delivery, request accounting, and 401 responses with and without capability metadata.

Validation:

  • The capability regression fails with HTTP 404 before the routing fix.
  • Backend self-tests: 59 passed.
  • Configuration-source parametric tests: 29 passed against the exact Linux CPython 3.11 release wheel from feat(openfeature): support dependent flags on Python delivery paths dd-trace-py#21346 at 352cbe0.
  • ./format.sh passes, including mypy, import policy, Python/YAML formatters, parser checks, and shellcheck.
  • Required review completed across all four lenses with no actionable findings.

Keep environment validation while allowing the dependent-flag capability parameter. Cover successful configuration, authorization responses, and invalid environments with capability negotiation enabled.

Environment: Datadog workspace

Co-Authored-By: Codex GPT-6 <noreply@localhost>
@hhan2024
hhan2024 requested review from a team as code owners November 6, 2026 21:24
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-06T21:26:28.563568Z 347d04c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

mirror_images.lock.yaml                                                 @DataDog/system-tests-core
mirror_images.yaml                                                      @DataDog/system-tests-core
tests/test_the_test/test_mock_ffe_agentless_backend.py                  @DataDog/feature-flagging-and-experimentation-sdk
utils/mocked_backend/_backend_ffe.py                                    @DataDog/feature-flagging-and-experimentation-sdk @DataDog/system-tests-core

@datadog-prod-us1-6

datadog-prod-us1-6 Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Pipelines  Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: d70adde | Docs | View more details | Give us feedback!

Synchronize the generated mirror manifest and locked digests with the PHP base image tags used by the scenarios so the GitLab freshness check passes.

Environment: Datadog workspace

Co-Authored-By: Codex GPT-6 <noreply@localhost>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant