Skip to content

RUM-19041: Clear pending RUM events when continuous profiling fails - #4002

Merged
0xnm merged 2 commits into
developfrom
nogorodnikov/rum-19041/clear-rum-events-on-continuous-failure
Oct 19, 2026
Merged

0xnm merged 2 commits into
developfrom
nogorodnikov/rum-19041/clear-rum-events-on-continuous-failure

Conversation

@0xnm

@0xnm 0xnm commented Oct 19, 2026

Copy link
Copy Markdown
Member

What does this PR do?

This is for the symmetry with successful outcome of the application launch run where pending RUM events are cleaned up.

Otherwise they simply stay in the memory until the next run.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@0xnm
0xnm requested review from a team as code owners October 19, 2026 10:14
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T10:17:58.130994Z 8e7d208 PR opened
🔒 Security Review ✅ Completed 2026-10-19T10:17:20.966513Z 8e7d208 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-official

datadog-official Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🔄 Datadog retried 3 tests - 3 passed on retry View in Datadog

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 71.77% (-0.09%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 6a3743c | Docs | View more details | Give us feedback!

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8e7d208895

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@datadog-official datadog-official Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

Clearing buffered long-task, ANR, and vital events after continuous-profiling failure matches the existing cleanup lifecycle. The completed static review identified no actionable regression.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit 8e7d208

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@0xnm 0xnm added the ready-for-human-review All agentic review feedback was addressed and PR is ready for the human review. label Oct 19, 2026
@0xnm
0xnm merged commit e9c3905 into develop Oct 19, 2026
27 checks passed
@0xnm
0xnm deleted the nogorodnikov/rum-19041/clear-rum-events-on-continuous-failure branch October 19, 2026 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human-review All agentic review feedback was addressed and PR is ready for the human review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants